Fixme List

Member swift::core::CApplication::registerAsRunning ()

KB 2017-11 maybe this code can be encapsulated somewhere

Member swift::core::CApplication::unregisterAsRunning ()

KB 2017-11 maybe this code can be encapsulated somewhere

Member swift::core::context::CContextNetwork::CContextNetwork (CCoreFacadeConfig::ContextMode, CCoreFacade *runtime)

KB 2019-07 bad style we implicitly depend on 2 other contexts

Member swift::core::db::CInfoDataReader::getCacheCount (swift::misc::network::CEntityFlags::Entity entity) const

bit of a hack to use web data services here

Member swift::core::db::CInfoDataReader::getCacheTimestamp (swift::misc::network::CEntityFlags::Entity entity) const

bit of a hack to use web data services here

Member swift::core::fsd::CFSDClient::sendFlightPlan (const swift::misc::aviation::CFlightPlan &flightPlan)

that would be the official string, can this be used?

Member swift::gui::CEnableForFramelessWindow::setWindowAttributes (WindowMode mode)

further improve transparent widget, try out void QWidget::setMask

Member swift::gui::CGuiUtility::checkBoxReadOnly (QCheckBox *checkBox, bool readOnly)

hardcoded stylesheet setting, should come from stylesheet

Member swift::gui::components::CDbLoadOverviewComponent::CDbLoadOverviewComponent (QWidget *parent=nullptr)

KB 201709 It is hard to judge if it is a good idea to trigger cache admit in a UI component

Member swift::gui::components::CDbMappingComponent::CDbMappingComponent (QWidget *parent=nullptr)

vPilot merging will be most likely removed in the future

Member swift::gui::components::CDbOwnModelSetComponent::CDbOwnModelSetComponent (QWidget *parent=nullptr)

hardcoded style sheet

Member swift::gui::COverlayMessages::showOverlayMessages (const swift::misc::CStatusMessageList &messages, bool appendOldMessages=false, std::chrono::milliseconds timeout=std::chrono::milliseconds(0))

KB 2017-09 a possible alternative maybe is to resize rows always to content -> performance?

Class swift::gui::COverlayMessagesBase< WIDGET >

KB 2017-12 all header version, if someone manages to create a cpp version go ahead, I failed on gcc with "undefined reference to `swift::gui::COverlayMessagesBase<QFrame>::showOverlayMessages`"

Member swift::gui::views::CAircraftCategoryTreeView::updateContainer (const swift::misc::aviation::CAircraftCategoryList &categories)

2019-02 workaround for HEAP: Free Heap block 000001AB439BFFF0 modified at 000001AB439C00BC after it was freed

Member swift::gui::views::CViewBase< T >::rowOf (const ObjectType &obj) const

KB 4-19 any smarter solution?

Member swift::gui::views::CViewBaseNonTemplate::fullResizeToContents ()

2019-04 Disabled the magic FOO trick for resizing Not working anymore and NOT needed ??? anymore, seems like resize to maximum magic trick from: http://stackoverflow.com/q/3433664/356726 this->setVisible(false); const QRect vpOriginal = this->viewport()->geometry(); if (m_forceColumnsToMaxSize) { vpNew.setWidth(std::numeric_limits<qint32>::max()); // largest finite value QGuiApplication::screens(); const QRect screenGeometry = sGui->currentScreen()->geometry(); QRect vpNew = vpOriginal; vpNew.setWidth(screenGeometry.width()); this->viewport()->setGeometry(vpNew); }

Member swift::misc::aviation::CFlightPlan::MaxRemarksLength

max.length of complete flight plan is 768 characters, this here is an assumption and should be part of the underlying network layers

Class swift::misc::CAtomicFile

Consider using QSaveFile.

Member swift::misc::CIdentifier::isFromLocalMachine () const

KB 2019-02 wonder if we should check on id (strict) or machine name (lenient)

Member swift::misc::simulation::fscommon::CVPilotRulesReader::standardMappingsDirectory ()

not threadsafe

Member swift::misc::startDetachedWithConsoleWindow (const QString &program, const QStringList &arguments)

Handle Linux and OS X here

Member swift::simplugin::flightgear::CSimulatorFlightgear::updateOwnSimulatorSelcal (const swift::misc::aviation::CSelcal &selcal, const swift::misc::CIdentifier &originator)

KB 8/2017 use SELCAL??

Member swift::simplugin::fs9::CDirectPlayPeer::sendMessage (const QByteArray &data)

KB 201707, style? pBufferData = const_cast<BYTE *>(reinterpret_cast<const BYTE *>(message.data()));

Member swift::simplugin::fs9::CSimulatorFs9::CSimulatorFs9 (const swift::misc::simulation::CSimulatorPluginInfo &info, const QSharedPointer< CFs9Host > &fs9Host, const QSharedPointer< CLobbyClient > &lobbyClient, swift::misc::simulation::IOwnAircraftProvider *ownAircraftProvider, swift::misc::simulation::IRemoteAircraftProvider *remoteAircraftProvider, swift::misc::network::IClientProvider *clientProvider, QObject *parent=nullptr)

KB 7/2017 change or remove comment when reviewed Could we just use: connect(lobbyClient.data(), &CLobbyClient::disconnected, this, &CSimulatorFs9::disconnectFrom);

Member swift::simplugin::fsxcommon::CSimulatorFsxCommon::SimConnectProc (SIMCONNECT_RECV *pData, DWORD cbData, void *pContext)

FSUIPC vs SimConnect why is offset 19 ident 2/0? In FSUIPC it is 0/1, according to documentation it is 0/1 but I receive 2/0 here. Whoever knows, add comment or fix if wrong

Member swift::simplugin::xplane::CSimulatorXPlane::updateOwnSimulatorSelcal (const swift::misc::aviation::CSelcal &selcal, const swift::misc::CIdentifier &originator)

KB 8/2017 use SELCAL??

Member XSwiftBus::CSettingsProvider::getSettings () const

Does this really need to be threadsafe?

Member XSwiftBus::CSettingsProvider::setSettings (const CSettings &settings)

Does this really need to be threadsafe?